Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSR-16 cache #1741

Merged
merged 1 commit into from
Feb 26, 2017
Merged

PSR-16 cache #1741

merged 1 commit into from
Feb 26, 2017

Conversation

chillu
Copy link
Member

@chillu chillu commented Feb 23, 2017

This was referenced Feb 23, 2017
Merged
Closed
@sminnee sminnee merged commit 6bae804 into silverstripe:master Feb 26, 2017
@tractorcow tractorcow deleted the pulls/4.0/6252-psr-cache branch February 26, 2017 02:51
@chillu
Copy link
Member Author

chillu commented Feb 26, 2017

@sminnee @tractorcow Thanks for merging! :) This merge broke the build, but not because of anything in the merge itself, but rather the fact that it's defaulting to [email protected]: https://travis-ci.org/silverstripe/silverstripe-cms/jobs/205416364. Given the constraint is set to ^4.0@dev with minimum-stability: stable, I'd expect it to choose 4.0.x-dev (we don't have prefer-stable: true set).

@tractorcow
Copy link
Contributor

Try removing --prefer-dist from composer install in cms tests .travis.yml. The @dev already overrides min-stability, but it doesn't override the prefer-dist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chillu @tractorcow @sminnee