Allow multibyte to be configured (fixes #605)

[wilr]

No description provided.

[GuySartorelli]

I'm going to close this due to lack of action. If someone would like to pick up this work feel free to create a new PR with the requested change applied.

[wilr]

Hi @GuySartorelli What diud you want to see changed? As per my last comment the requested changes I don't agree with and as @lerni pointed out - the fix does what it says on the tin

[wilr]

Perhaps it would have been better if the trait was a DataExtension so that config is automatically applied to DataObjects it is applied to.

Perhaps it would be that would require a major API change compared to the current proposed fix which retains existing API.

[GuySartorelli]

Sounded like Steve was leaning towards preferring an extension to update the value, e.g.

$allowMultiByte = true;
$this->extend('updateAllowUrlSegmentMultibyte', $allowMultiByte);
$filter->setAllowMultibyte($allowMultiByte);

Personally I do prefer the config approach, so I'd probably be okay with your existing PR if the config name was a little more specific - allow_multibyte could easily be used as a config name for allow multibyte for just about any purpose entirely unrelated to this specific use case. If you changed it so something more like allow_urlsegment_multibyte I would be okay with it.

It is preferable to declare private static for new config, but you can't override it on the class if you add that to the trait. Perhaps the solution that would satisfy Steve then is to add those private static declarations on the classes included in this module which do use the trait, so it is explicitly declared where we have the control to do so.

[wilr]

@GuySartorelli Done.

[GuySartorelli]

Nice, thanks for that. Just a small change to make per below.

[GuySartorelli]

Looks good to me. Thanks.

[lerni]

Now in BlogController.php rawurlencode is triggered based on the mb-config from URLSegmentFilter but it should respect SilverStripe\Blog\Model\BlogTag & SilverStripe\Blog\Model\BlogCategory: allow_urlsegment_multibyte config value in order to show BlogPosts associated with Tags/Categories that actually have mb-characters like umlauts in it.