Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix category and tag buttons using input groups from bootstrap #624

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Fix category and tag buttons using input groups from bootstrap #624

merged 1 commit into from
Oct 2, 2020

Conversation

MarcioBarrientos
Copy link
Contributor

@MarcioBarrientos MarcioBarrientos commented Oct 1, 2020 •
edited
Loading

This fixes the category and tag button layout. #614
Captura de Pantalla 2020-10-01 a la(s) 03 09 29

dhensby
dhensby suggested changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@dhensby dhensby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a more generic solution than relying on there being only 2 fields

templates/SilverStripe/Blog/Forms/GridField/GridFieldAddByDBField.ss Outdated Show resolved Hide resolved
@dhensby
Copy link
Contributor

dhensby commented Oct 1, 2020

@MarcioBarrientos can you squash your two commits, please? Then I think this is good to merge

@dhensby dhensby merged commit 053660e into silverstripe:3.5 Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhensby dhensby dhensby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcioBarrientos @dhensby