ENH Add generic types #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
requested changes
Jan 17, 2024
code/AuditHookManyManyList.php
Outdated
| @@ -11,6 +11,8 @@ | |||
| /** | |||
| * AuditHookManyManyList is meant to override ManyManyList. When a Member is | |||
| * removed from a Group, it logs the event. | |||
| * | |||
| * @extends ManyManyList<Member> | |||
There was a problem hiding this comment.
This means it extends a ManyManyList that contains a list of Members correct?
However silverstripe/auditor will use injector swap out ALL ManyManyList with AuditHookManyManyList ... so <Member> could be anything
Is the assumption here that if you manually instantiate an AuditHookManyManyList it would only be for Members?
There was a problem hiding this comment.
Ahh. For some reason in my brain this was only replacing ManyManyList when it's explicitly a list of members, but as you pointed out that's not necessarily the case. I'll update to template T of dataobject.
GuySartorelli
force-pushed
the
pulls/3/add-generics
branch
from
0244a1f
to
5feb53a
Compare
emteknetnz
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires silverstripe/silverstripe-framework#11108 for these generics to take effect.
Issue