Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Set extension hook implementation visibility to protected #605

Merged
merged 1 commit into from
May 21, 2024
Merged

API Set extension hook implementation visibility to protected #605

merged 1 commit into from
May 21, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request May 16, 2024
Closed
3 tasks
@emteknetnz emteknetnz force-pushed the pulls/3/protect-hooks branch from b4e73a6 to cdc6399 Compare May 17, 2024 03:30
@emteknetnz emteknetnz force-pushed the pulls/3/protect-hooks branch from cdc6399 to 5a3231d Compare May 20, 2024 04:57
GuySartorelli
GuySartorelli approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were a couple of methods there being changed that aren't on Extension subclasses - but they do look like they should change anyway so that's okay.

LGTM

@GuySartorelli GuySartorelli merged commit 170fc27 into silverstripe:3 May 21, 2024
9 checks passed
@GuySartorelli GuySartorelli deleted the pulls/3/protect-hooks branch May 21, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli