Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ReadOnlyCacheService #1070

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Apr 12, 2020

New PR #1078

Utilise the new ReadOnlyCacheService in the asset module, if available

This will speed up the read-only graphql requests within the cms file manager

Related PR assets: silverstripe/silverstripe-assets#388

Note: despite name of branch, this was rebased to be branched off 1 instead of 1.5

@emteknetnz emteknetnz force-pushed the pulls/1.5/use-dbfile-exists-cache branch 2 times, most recently from 16be308 to aaa1a07 Compare April 13, 2020 07:38
@emteknetnz emteknetnz changed the title WIP: Enable ReadOnlyCacheService Enable ReadOnlyCacheService Apr 15, 2020
@emteknetnz emteknetnz force-pushed the pulls/1.5/use-dbfile-exists-cache branch from aaa1a07 to 876d2f0 Compare April 15, 2020 05:56
@Cheddam
Copy link
Member

Cheddam commented Apr 20, 2020

Seems better to point this (along with the other PR) at the 1 branch instead of introducing it as a non-functional patch to 1.5?

@emteknetnz emteknetnz changed the base branch from 1.5 to 1 April 20, 2020 10:21
@emteknetnz emteknetnz force-pushed the pulls/1.5/use-dbfile-exists-cache branch 2 times, most recently from cfdb206 to 24420c0 Compare April 20, 2020 10:34
@emteknetnz emteknetnz force-pushed the pulls/1.5/use-dbfile-exists-cache branch from 24420c0 to b508314 Compare April 20, 2020 10:36
@emteknetnz
Copy link
Member Author

@Cheddam yup agree with that, have rebased and pointed at 1

@emteknetnz
Copy link
Member Author

Getting a weird error in travis related to git-diff to do with a previously rebuilt css file. Something seems to have gone weird when I did the rebase on to 1 so I'll just redo this PR here #1078

@emteknetnz emteknetnz closed this Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants