Merge pull request #1461 from creative-commoners/pulls/3/protect-hooks

API Set extension hook implementation visibility to protected
silverstripe · May 21, 2024 · 596fb02 · 596fb02
2 parents 302278d + ecbc8b3
commit 596fb02
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/code/Controller/AssetAdminFile.php b/code/Controller/AssetAdminFile.php
@@ -35,7 +35,7 @@ class AssetAdminFile extends DataExtension
      */
     private static $insert_height = 400;
 
-    public function updateCMSEditLink(&$link)
+    protected function updateCMSEditLink(&$link)
     {
         // Update edit link for this file to point to the new asset admin
         $controller = AssetAdmin::singleton();

diff --git a/code/Extensions/CampaignAdminExtension.php b/code/Extensions/CampaignAdminExtension.php
@@ -22,7 +22,7 @@ class CampaignAdminExtension extends Extension
      * @param array $actions
      * @param File $record
      */
-    public function updatePopoverActions(&$actions, $record)
+    protected function updatePopoverActions(&$actions, $record)
     {
         if (!Permission::check('CMS_ACCESS_CampaignAdmin')) {
             return;

diff --git a/code/Extensions/UsedOnTableExtension.php b/code/Extensions/UsedOnTableExtension.php
@@ -19,7 +19,7 @@ class UsedOnTableExtension extends Extension
     /**
      * @var array $excludedClasses
      */
-    public function updateUsageExcludedClasses(array &$excludedClasses)
+    protected function updateUsageExcludedClasses(array &$excludedClasses)
     {
         $excludedClasses[] = FileLink::class;
         $excludedClasses[] = Member::class;
@@ -28,7 +28,7 @@ public function updateUsageExcludedClasses(array &$excludedClasses)
     /**
      * @param DataObject $dataObject|null
      */
-    public function updateUsageDataObject(?DataObject &$dataObject)
+    protected function updateUsageDataObject(?DataObject &$dataObject)
     {
         if ($dataObject instanceof Folder) {
             $dataObject = null;