API Deprecate API that will be renamed #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
emteknetnz
requested changes
Oct 30, 2024
code/CMSProfileController.php
Outdated
| @@ -20,6 +20,9 @@ class CMSProfileController extends LeftAndMain | |||
|
|
|||
| private static $required_permission_codes = 'CMS_ACCESS'; | |||
|
|
|||
| /** | |||
| * @deprecated 5.4.0 Will be renamed model_class | |||
There was a problem hiding this comment.
Suggested change
| * @deprecated 5.4.0 Will be renamed model_class | |
| * @deprecated 5.4.0 Will be renamed to $model_class |
Update here and in all other files in all all the PRs
GuySartorelli
force-pushed
the
pulls/2/deprecation-singlemodeladmin
branch
from
7d16344 to
ee8d86f
Compare
emteknetnz
approved these changes
Oct 31, 2024
Kevinn1109
pushed a commit
to Kevinn1109/silverstripe-admin
that referenced
this pull request
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
LeftAndMaininto its own class #1764