API Standardise extension hooks #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Aug 18, 2024
| $this->extend('init'); | ||
| $this->extend('onInit'); |
There was a problem hiding this comment.
Intentionally not changing to onAfterInit because this isn't at the end of the method.
Also not updateInit because it's not updating the value of some argument.
GuySartorelli
force-pushed
the
pulls/3/standardise-extension-hooks
branch
from
694e906
to
b0c17b1
Compare
GuySartorelli
force-pushed
the
pulls/3/standardise-extension-hooks
branch
from
b0c17b1
to
17b432d
Compare
emteknetnz
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue