DEP Remove remaining cwp dependencies and code #55
Conversation
emteknetnz
force-pushed
the
pulls/6/remove-watea
branch
2 times, most recently
from
a4a4842 to
85678c0
Compare
emteknetnz
changed the title
emteknetnz
force-pushed
the
pulls/6/remove-watea
branch
from
85678c0 to
c0fa387
Compare
app/_config/environmentcheck.yml
Outdated
There was a problem hiding this comment.
This was here in part as a way to validate that environmentcheck is working in kitchen sink.
Please keep the top config (which doesn't actually depend on anything CWP related) and just rename it to not say "cwp".
There was a problem hiding this comment.
Updated, though have removed the cwp-search bit since there's no CMS 6 module for that
There was a problem hiding this comment.
Good, that's what I intended by "keep the top config" - "do not keep the bottom config" was implied. 👍
app/_config/theme.yml
Outdated
There was a problem hiding this comment.
Please just replace watea and starter with simple but otherwise keep this, unless an identical theme.yml is provided by one of kitchen sink's dependencies.
composer.json
Outdated
| "project-files": [ | ||
| "app/*" | ||
| ], |
There was a problem hiding this comment.
Need to keep this if we're keeping some of the above.
emteknetnz
force-pushed
the
pulls/6/remove-watea
branch
from
c0fa387 to
ab16e9b
Compare
Issue silverstripe/.github#199
Requires silverstripe/silverstripe-versionfeed#101 to fix the recipe-contents blocks jobs, and will need to be merged up as that PR is targetting 4.13 and this is a 6 build