ENH Restrict which repos get dispatch-ci #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/main/dispatch-ci
branch
2 times, most recently
from
772c190
to
5fe7e57
Compare
GuySartorelli
requested changes
Feb 15, 2024
emteknetnz
force-pushed
the
pulls/main/dispatch-ci
branch
from
5fe7e57
to
905f5fb
Compare
| write_file_even_if_exists('.github/workflows/dispatch-ci.yml', $content); | ||
| $dispatchCiPath = '.github/workflows/dispatch-ci.yml'; | ||
| $ciPath = '.github/workflows/ci.yml'; | ||
| $shouldHaveDispatchCi = (is_module() || is_composer_plugin()) && !is_docs() && !is_gha_repository(); |
There was a problem hiding this comment.
Realistically I think is_module() || is_composer_plugin() is all that's needed here, but doesn't hurt to be explicit so it can stay as is.
GuySartorelli
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #37
Note I ended up putting in some checking for is_meta_repo() aka .github repo which recently was added, this is required otherwise you cannot do a full dry-run
We want still want dispatch-ci on composer-plugins() specifically for vendor-plugin() which integrates with other things - https://github.com/silverstripe/vendor-plugin/actions/runs/7871071271
recipe-plugin() only does linting, so it's a bit pointless being on a cron like this though it's cleaner to just keep it on dispatch-ci - https://github.com/silverstripe/recipe-plugin/actions/runs/7854707347
should_use_dispatch_ci() will return as follows for the repos: