Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW Output endtoend_tag #99

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

emteknetnz
Copy link
Member

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when the other CI PRs are approved

@GuySartorelli
Copy link
Member

Was about to merge these CI PRs, but this one targets 1.15 while the other two target 1. What's more, the PR branch for silverstripe/gha-ci#136 is 1.12 but the one for silverstripe/gha-run-tests#31 is 1... so it's not clear which branch any of these should be targetting, but seems like at least one is targetting the wrong branch?

@emteknetnz
Copy link
Member Author

emteknetnz commented Jul 18, 2024

Ah up, the gha-ci was targetting 1 when it should have targetted 1.12. The others are correct, it's based on whether there are API changes or not

@GuySartorelli GuySartorelli merged commit 0a147f3 into silverstripe:1.15 Jul 18, 2024
4 checks passed
@GuySartorelli GuySartorelli deleted the pulls/1.15/tag branch July 18, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants