MNT New PHP 8.3 support #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
sabina-talipova
force-pushed
the
pulls/1/support-php-83
branch
16 times, most recently
from
688f339 to
f8ea85a
Compare
sabina-talipova
commented
Nov 22, 2023
sabina-talipova
force-pushed
the
pulls/1/support-php-83
branch
from
f8ea85a to
ac96844
Compare
sabina-talipova
commented
Dec 12, 2023
GuySartorelli
requested changes
Dec 12, 2023
There was a problem hiding this comment.
This currently generates the following matrix for PHPUnit tests:
- 8.1 prf-low mysql57 phpunit
- 8.1 mariadb phpunit
- 8.2 mysql80 phpunit
- 8.3 mysql80 phpunit
It should instead generate this:
- 8.1 prf-low mysql57 phpunit
- 8.2 mariadb phpunit
- 8.3 mysql80 phpunit
Note that this removes the duplication of running two mysql80 runs.
sabina-talipova
force-pushed
the
pulls/1/support-php-83
branch
4 times, most recently
from
d4d0c8e to
3611430
Compare
sabina-talipova
force-pushed
the
pulls/1/support-php-83
branch
from
3611430 to
628434f
Compare
GuySartorelli
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue