FIX Fix logic to allow unit tests to pass #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/silverstripe/gha-generate-matrix/actions/runs/10804283992
The unit test started failing because we added
5.3as a minor version in silverstripe/supported-modules@32a718e but the unit tests dummy branches only go up to 5.2I considered adding
5.3and5.4to the dummy branches list, but we'd have the same problem again when we hit 6.1... no matter which dummy branches we add we'll eventually hit this problem again.Instead, I've updated the logic to allow for missing branches, so it uses the most recent existing minor branch for a given major release line.
Issue