Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP Update minimum composer versions #12

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz marked this pull request as ready for review December 9, 2024 05:48
@GuySartorelli
Copy link
Member

Can you please force push to try get CI to run?

@emteknetnz emteknetnz force-pushed the pulls/1.0/min-ver-composer branch from 0043180 to 48ca67e Compare December 10, 2024 00:59
@emteknetnz
Copy link
Member Author

I did. Does not seem to want to run 🤷

@GuySartorelli
Copy link
Member

Weird - for some reason the workflow is missing

on:
  pull_request

Can you please update it? Or create a card to do that if you wanna handle that separately - but would be nice to get it out of the way while we're looking at it.

@emteknetnz
Copy link
Member Author

I did create a pr #13 - however closed it as the only purpose of ci.yml it to dispatch tag-patch-release, which is not appropiate for a pull_request event

@GuySartorelli
Copy link
Member

Ahhh okay that makes sense.

@GuySartorelli GuySartorelli merged commit 02c4a9c into silverstripe:1.0 Dec 10, 2024
@GuySartorelli GuySartorelli deleted the pulls/1.0/min-ver-composer branch December 10, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants