DOC Use FieldValidators for FormFieldValidation #621
+64
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
emteknetnz
force-pushed
the
pulls/6/form-field-valid
branch
7 times, most recently
from
c27e818
to
74624d4
Compare
emteknetnz
force-pushed
the
pulls/6/form-field-valid
branch
2 times, most recently
from
516d1fb
to
53d015b
Compare
GuySartorelli
requested changes
Nov 20, 2024
emteknetnz
force-pushed
the
pulls/6/form-field-valid
branch
3 times, most recently
from
7a78385
to
0d23732
Compare
GuySartorelli
requested changes
Nov 25, 2024
emteknetnz
force-pushed
the
pulls/6/form-field-valid
branch
5 times, most recently
from
a171679
to
788373a
Compare
GuySartorelli
requested changes
Nov 26, 2024
| should trigger a validation error on the page) and pass this to the `extendValidationResult` method to allow extensions | ||
| to hook into the validation logic. In addition, in the event of failed validation, a useful error message must be set | ||
| on the given validator. | ||
| The `validate()` method returns a [`ValidationResult`](api:SilverStripe\Core\Validation\ValidationResult) object with any errors added to it, and should contain a useful error message. The `validate()` method should follow the example above and utilise the `$this->beforeExtending('updateValidate', ...` method and be followed by `return parent::validate();` in order for code in the parent class to be executed in the correct order. |
There was a problem hiding this comment.
Suggested change
| The `validate()` method returns a [`ValidationResult`](api:SilverStripe\Core\Validation\ValidationResult) object with any errors added to it, and should contain a useful error message. The `validate()` method should follow the example above and utilise the `$this->beforeExtending('updateValidate', ...` method and be followed by `return parent::validate();` in order for code in the parent class to be executed in the correct order. | |
| The `validate()` method returns a [`ValidationResult`](api:SilverStripe\Core\Validation\ValidationResult) object with any errors added to it, and should contain a useful error message. The `validate()` method should follow the example above and utilise the `$this->beforeExtending('updateValidate', ...)` method and be followed by `return parent::validate();` in order for code in the parent class to be executed in the correct order. |
As per #621 (comment)
emteknetnz
force-pushed
the
pulls/6/form-field-valid
branch
from
788373a
to
e939717
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#11422