Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Document new community roles #394

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli force-pushed the pulls/4.13/community-roles branch 2 times, most recently from f5c1824 to 8dc56e0 Compare November 12, 2023 21:45
@GuySartorelli GuySartorelli marked this pull request as ready for review November 12, 2023 21:45
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Is this target to 4.13 on purpose?

I'm thinking maybe we need to have a formal signed agreement before granting people access. But that can maybe be sorted out later.

en/06_Project_Governance/03_Maintainer_Guidelines.md Outdated Show resolved Hide resolved
en/06_Project_Governance/03_Maintainer_Guidelines.md Outdated Show resolved Hide resolved
en/06_Project_Governance/03_Maintainer_Guidelines.md Outdated Show resolved Hide resolved
en/06_Project_Governance/03_Maintainer_Guidelines.md Outdated Show resolved Hide resolved
en/06_Project_Governance/03_Maintainer_Guidelines.md Outdated Show resolved Hide resolved
en/06_Project_Governance/03_Maintainer_Guidelines.md Outdated Show resolved Hide resolved
en/06_Project_Governance/03_Maintainer_Guidelines.md Outdated Show resolved Hide resolved
en/06_Project_Governance/03_Maintainer_Guidelines.md Outdated Show resolved Hide resolved
@GuySartorelli
Copy link
Member Author

GuySartorelli commented Nov 26, 2023

Is this target to 4.13 on purpose?

Yes. Anything that affects both CMS 4 and 5 or which doesn't apply to a specific version should target 4.13 first and be merged up from there.

Ideally these pages wouldn't be stuck behind a version toggle - see silverstripe/doc.silverstripe.org#245
But since they are for now, this is the process we must follow to avoid the problem getting worse than it already is.

I'm thinking maybe we need to have a formal signed agreement before granting people access. But that can maybe be sorted out later.

Yup, we can update the docs if/when we have such an agreement.

Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there.

en/06_Project_Governance/03_Maintainer_Guidelines.md Outdated Show resolved Hide resolved
en/06_Project_Governance/03_Maintainer_Guidelines.md Outdated Show resolved Hide resolved
en/06_Project_Governance/03_Maintainer_Guidelines.md Outdated Show resolved Hide resolved
en/06_Project_Governance/03_Maintainer_Guidelines.md Outdated Show resolved Hide resolved
en/06_Project_Governance/03_Maintainer_Guidelines.md Outdated Show resolved Hide resolved
Copy link
Member Author

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The branch this PR is targetting now has a CI action. This PR will need to be force-pushed to run the CI, and the CI must be green before merging.

@GuySartorelli
Copy link
Member Author

Rebased and resolved conflicts, lint passes locally.

Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing left is a pedantic and egocentric argument about my Job title.

Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxime-rainville maxime-rainville merged commit 6314244 into silverstripe:4.13 Dec 4, 2023
3 checks passed
@maxime-rainville maxime-rainville deleted the pulls/4.13/community-roles branch December 4, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants