Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Add dev version of framework #59

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jul 10, 2024

Issue silverstripe/.github#284

Required to be at least 4.10 use phpunit 9.5 for --prefer-lowest build

Though also required to be at least 4.11 otherwise there's an issue with egulias/email-validator

https://github.com/silverstripe/comment-notifications/actions/runs/9851667978/job/27243763017

@emteknetnz emteknetnz force-pushed the pulls/2.4/composer branch 2 times, most recently from 0a0feab to 489c282 Compare July 10, 2024 01:17
@emteknetnz emteknetnz force-pushed the pulls/2.4/composer branch from 489c282 to 469dc75 Compare July 10, 2024 01:21
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 70755e7 into silverstripe:2.4 Jul 10, 2024
9 checks passed
@GuySartorelli GuySartorelli deleted the pulls/2.4/composer branch July 10, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants