Update PHP to 8.1, plus some enhancements #108
Conversation
GuySartorelli
force-pushed
the
pulls/master/php-81
branch
from
205935d
to
990cd10
Compare
There was a problem hiding this comment.
This file is easiest to read by just viewing the actual raw file directly, rather than seeing the diff, since I have copied the class.twig file from doctum itself, and then re-applied any changes as appropriate.
There was a problem hiding this comment.
This file is easiest to read by just viewing the actual raw file directly, rather than seeing the diff - it's ultimately just adding in the google analytics snippet, the rest of the JS template has changed so completely in doctum that any other customisations no longer apply.
src/Console/CheckoutCommand.php
Outdated
There was a problem hiding this comment.
Changes to this file were necessary to match changes in symfony/console
| @@ -12,9 +13,19 @@ class ApiJsonStore extends JsonStore | |||
| { | |||
| public function removeClass(Project $project, $name) | |||
| { | |||
| $path = $this->getFilename($project, $name); | |||
There was a problem hiding this comment.
The signature for getFilename() changed - it was easier to just refactor this method to call the parent method and ignore the exception.
src/Inspections/RecipeFinder.php
Outdated
There was a problem hiding this comment.
Required to match changes in symfony/finder
GuySartorelli
force-pushed
the
pulls/master/php-81
branch
from
990cd10
to
e168eff
Compare
Required also updating various dependencies.
There was code there to do this already, but it seems like it just never got finished.
GuySartorelli
force-pushed
the
pulls/master/php-81
branch
from
e168eff
to
ac4cf19
Compare
Changes in this PR
Each of these changes has its own commit. You can review the commits individually if that makes peer review easier.
The commits should all remain distinct - DO NOT SQUASH