Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.2 updates #105

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Conversation

cviebrock
Copy link

Some fixes for PHP 8.2, and code-quality improvements:

  • add PHPstan and Rector to quality tooling
  • switch to php-cs-fixer for linting
  • convert "MyClass" to MyClass::class
  • other fixes: various typos, code smells, and other issues identified by phpstan/rector

Note: the return value for the following methods has changed, so it will likely mean updates to projects and other packages that rely on Admin:

  • AdminDBConfirmation::processDBData(): void
  • AdminEdit::validate(): bool
  • AdminConfirmation::prorcessResponse(): bool

Note: because of the above, the logic in 66e8fbf needed a refactor. Please confirm that my approach makes sense (i.e. a null would have been treated like false in a comparison check, so returning false makes sense in that context).

@cviebrock cviebrock marked this pull request as ready for review September 19, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant