[DRAFT] feature: support running liquid tests for account templates #130
+123
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support running liquid tests for account templates
Some example templates to test you can find here: account_templates.zip
The tests run, but there seem to be two issues that at first glance might be core issues that ENG needs to solve:
When I run the tests on this template on the platform: https://live.getsilverfin.com/f/14400/account_detail_templates/492722/edit
All the tests pass on the platform.
But running that exact same test suite with the API, results in a different reconciled expectation output:
Running the test with only expected input view rendered for the template:
Still results in the export view being returned by the API:
Type of change
Bug fixBreaking changeChecklist
README updated (if needed)Documentation updated (if needed)