Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] feature: support running liquid tests for account templates #130

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Woetfin
Copy link
Contributor

@Woetfin Woetfin commented May 17, 2024

Description

Support running liquid tests for account templates

Some example templates to test you can find here: account_templates.zip

The tests run, but there seem to be two issues that at first glance might be core issues that ENG needs to solve:

  1. Difference in reconciled expectation output on platform compared to API

When I run the tests on this template on the platform: https://live.getsilverfin.com/f/14400/account_detail_templates/492722/edit

All the tests pass on the platform.
Screenshot 2024-05-23 at 10 43 20

But running that exact same test suite with the API, results in a different reconciled expectation output:
Screenshot 2024-05-23 at 10 44 20

  1. The HTML seems to always return the export view of the template, even if mode "input" or "all" is specified:

Running the test with only expected input view rendered for the template:
Screenshot 2024-05-23 at 10 47 04

Still results in the export view being returned by the API:
Screenshot 2024-05-23 at 10 30 35

Type of change

  • Bug fix
  • New feature
  • Breaking change

Checklist

  • README updated (if needed)
  • Version updated (if needed)
  • Documentation updated (if needed)

@Woetfin Woetfin changed the title features: support running liquid tests for account templates feature: support running liquid tests for account templates May 17, 2024
@Woetfin Woetfin self-assigned this May 17, 2024
@Woetfin Woetfin requested a review from Toby-Masters-SF May 21, 2024 14:11
@Woetfin Woetfin force-pushed the run-liquid-tests-for-account-templates branch from 0adec3a to b6d1209 Compare May 23, 2024 08:52
@AgustinSilverfin AgustinSilverfin changed the title feature: support running liquid tests for account templates [DRAFT] feature: support running liquid tests for account templates Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant