Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Update(before, after) API for senses #1267

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rmunn
Copy link
Contributor

@rmunn rmunn commented Nov 25, 2024

Fix #1186.

Adds a new UpdateSense(Guid entryId, Sense before, Sense after) method to the IMiniLcmWriteApi interface.

Also adds a GetSense(Guid entryId, Guid id) method to the IMiniLcmReadApi interface.

@rmunn rmunn requested a review from hahn-kev November 25, 2024 06:32
@rmunn rmunn self-assigned this Nov 25, 2024
Copy link

C# Unit Tests

90 tests  ±0   90 ✅ ±0   5s ⏱️ ±0s
14 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 21252a1. ± Comparison against base commit 3a69401.

Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a good start, though SenseDiffToUpdateneeds to be changed to remove the code doing the diff on semantic domains and instead in in SenseSync.Sync it needs to do a collection diff and use the apis AddSemanticDomainToSense and the remove variant, if there's any differences between the same domains those should be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement new update api Senses
2 participants