Implement new update API for writing systems #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that FwDataMiniLcmApi hasn't implemented the UpdateWritingSystem overload with (id, type, update), which is the (before, after) method is going to end up calling. So that still needs to happen.
GUID Id vs string WsId is still an issue, as is the Font/Fonts issue.
|
Decision during yesterday's team meeting: for now, Font will remain a single string and will be used to indicate the default font in LCM (DefaultFontName property). DefaultFontName is read-only in LCM, so if it changes on the CRDT side, we should instead use its new value to look up the name of a font and set the DefaultFont property in LCM, e.g.: ws.DefaultFont = new FontDefinition("Charis SIL"); |
hahn-kev
requested changes
Nov 25, 2024
There was a problem hiding this comment.
we should really avoid using the WritingSystem Id property which is a Guid, maybe we mark it obsolete or something? There's a number of places where we really don't want to use it at all as there's no counterpart in Fieldworks. I left some comments to that end. Maybe we hide that field as it's really only required for Crdts.
hahn-kev
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1189.
Note that FwDataMiniLcmApi hasn't implemented the UpdateWritingSystem overload with (id, type, update), which the (before, after) method is going to end up calling. So that still needs to happen.