Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update projects to target dotnet 9 #1057

Merged
merged 38 commits into from
Nov 28, 2024
Merged

update projects to target dotnet 9 #1057

merged 38 commits into from
Nov 28, 2024

Conversation

hahn-kev
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

C# Unit Tests

98 tests   98 ✅  5s ⏱️
15 suites   0 💤
 1 files     0 ❌

Results for commit 082476e.

♻️ This comment has been updated with latest results.

@rmunn
Copy link
Contributor

rmunn commented Sep 24, 2024

Curious what the benefit of moving to .NET 9 is, specifically. Is it the HybridWebView control in MAUI that we want to use? Or is this just on general principles of keeping up with the latest .NET version?

@hahn-kev
Copy link
Collaborator Author

It's just keeping up with the latest version as it comes out, in my mind we should always be on latest unless there's a specific reason not to be.

@hahn-kev
add setup maui to build and test workflow for fw lite
f8dbc6c
@hahn-kev
add setup dotnet to integration-test-gha.yaml
97cc436
@hahn-kev
Merge branch 'develop' into chore/dotnet-9
d914b43
@hahn-kev
Merge branch 'develop' into chore/dotnet-9
1cd3936
@hahn-kev
Merge branch 'develop' into chore/dotnet-9
73cf3af 
# Conflicts:
#	.github/workflows/lexbox-api.yaml
#	backend/FwLite/FwDataMiniLcmBridge/FwDataMiniLcmBridge.csproj
#	backend/FwLite/FwLiteProjectSync/FwLiteProjectSync.csproj
#	backend/FwLite/LcmCrdt/LcmCrdt.csproj
#	backend/FwLite/MiniLcm/MiniLcm.csproj
@hahn-kev
fix tests project not building due to a target framework mismatch
c925d3e
@hahn-kev
fix LcmDebugger.csproj
fe66a6e
@rmunn
Copy link
Contributor

rmunn commented Nov 13, 2024

.NET 9 is now officially released. It hasn't shown up in the Ubuntu repositories yet, but that's only a matter of time.

@hahn-kev
upgrade npgsql, linq2db efcore
5f0bfef
@hahn-kev
update FixFwData.csproj details
53c7805
@hahn-kev
Merge branch 'develop' into chore/dotnet-9
e976c79 
# Conflicts:
#	.github/workflows/fw-lite.yaml
#	backend/FwLite/LocalWebApp/Routes/HistoryRoutes.cs
#	backend/FwLite/MiniLcm.Tests/MiniLcm.Tests.csproj
#	backend/FwLite/MiniLcm/MiniLcm.csproj
#	backend/harmony
@hahn-kev
update harmony to latest deps
edaad2b
@hahn-kev
fix warning 'Multiple test adapters with the same uri 'executor://xun…
c304eb1 
…it/VsTestRunner2/netcoreapp' were found. Ignoring adapter 'Xunit.Runner.VisualStudio.VsTestRunner'. Please uninstall the conflicting adapter(s) to avoid this warning.'
@hahn-kev
fix issue where test crashes and doesn't cleanup
d7fbb91
@hahn-kev
update dotnet-ef tool name
6d851eb
@hahn-kev
upgrade EntityFrameworkCore.Projectables
ae29a4f
@hahn-kev
Copy link
Collaborator Author

looks like our current test failure is running into this bug
dotnet/efcore#35110
Sadly I'm not sure how to make a simple repro, so I'm going to wait and see if someone else comes up with something

@hahn-kev
disable warning about pending model changes which is currently bugged
b7f7f70
@hahn-kev
Merge branch 'develop' into chore/dotnet-9
38bf034 
# Conflicts:
#	backend/FwLite/FwLiteProjectSync.Tests/FwLiteProjectSync.Tests.csproj
#	backend/FwLite/LcmCrdt.Tests/LcmCrdt.Tests.csproj
@hahn-kev hahn-kev marked this pull request as ready for review November 21, 2024 02:07
@hahn-kev
fix issue with recursive error when getting snapshots
1a95a58
@hahn-kev
Merge branch 'develop' into chore/dotnet-9
cf81572 
# Conflicts:
#	backend/FwLite/FwDataMiniLcmBridge.Tests/FwDataMiniLcmBridge.Tests.csproj
#	backend/FwLite/FwLiteProjectSync.Tests/FwLiteProjectSync.Tests.csproj
#	backend/FwLite/LcmCrdt.Tests/LcmCrdt.Tests.csproj
#	backend/FwLite/MiniLcm.Tests/MiniLcm.Tests.csproj
#	backend/LexBoxApi/LexBoxApi.csproj
@hahn-kev
correct nuget versions in lcm bridge
1445993
@hahn-kev
fix build by including harmony/Directory.Packages.props and some othe…
87a7541 
…r missing files in docker builds
@hahn-kev
revert to EF 8
ef1fe12
@hahn-kev
also change LcmCrdt ef core version
ed9789c
@hahn-kev
verification test for lcmCrdt db model
01aa825
@hahn-kev hahn-kev requested a review from myieye November 28, 2024 02:41
@hahn-kev
Merge branch 'develop' into chore/dotnet-9
1eed8a7 
# Conflicts:
#	backend/FwLite/FwLiteProjectSync.Tests/FwLiteProjectSync.Tests.csproj
@hahn-kev
fix test failure caused by openProject expecting the grid view to be …
3001c3f 
…active
@hahn-kev
define --prod-ui-build in tilt to make running playwright tests mor…
082476e 
…e reliable as the vite server doesn't work well with playwright tests
@github-actions GitHub Actions
Copy link

UI unit Tests

12 tests   12 ✅  0s ⏱️
 4 suites   0 💤
 1 files     0 ❌

Results for commit 082476e.

@hahn-kev hahn-kev merged commit 7f157e7 into develop Nov 28, 2024
22 checks passed
@hahn-kev hahn-kev deleted the chore/dotnet-9 branch November 28, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myieye myieye Awaiting requested review from myieye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hahn-kev @rmunn @myieye