feat: add poll interval arg #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vid201
reviewed
Dec 28, 2023
There was a problem hiding this comment.
Cool, I like this solution, LGTM
The reason we had 5 milliseconds was for bundler spec tests to pass successfully, not sure if the tests will go through with 500 (due to mempool not being cleaned fast enough). But updating the debug_sendBundleNow RPC method (as explained in #253 ) should fix the problem and work with 500 IMO.
Maybe we can update the RPC method in this PR as well
zsluedem
force-pushed
the
add-poll-interval-args
branch
from
861b9e4 to
10a326b
Compare
|
#253 is not descriptive enough. I don' understand. Let's go with the current version now. |
zsluedem
force-pushed
the
add-poll-interval-args
branch
from
10a326b to
187e1db
Compare
zsluedem
force-pushed
the
add-poll-interval-args
branch
from
187e1db to
7c816c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add poll interval arg fix #229