Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bundler conformance to latest specs, handle reputation #226

Merged
merged 2 commits into from
Oct 16, 2023
Merged

feat: bundler conformance to latest specs, handle reputation #226

merged 2 commits into from
Oct 16, 2023

Conversation

Vid201
Copy link
Member

@Vid201 Vid201 commented Oct 13, 2023

This PR ended up a little bigger than firstly anticipated :octocat:

@Vid201 Vid201 linked an issue Oct 13, 2023 that may be closed by this pull request
Reputation rules #222
Closed
@Vid201 Vid201 requested a review from zsluedem October 13, 2023 23:29
zsluedem
zsluedem approved these changes Oct 15, 2023
View reviewed changes
Copy link
Collaborator

@zsluedem zsluedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question. Others looks good.

crates/grpc/src/bundler.rs Show resolved Hide resolved
@Vid201 Vid201 merged commit cbd6735 into main Oct 16, 2023
2 checks passed
@Vid201 Vid201 deleted the feat/new_spec_tests branch October 16, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsluedem zsluedem zsluedem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reputation rules
2 participants
@Vid201 @zsluedem