Generate type safe bindings for abstract accounts (#4) #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsluedem
commented
Nov 25, 2022
zsluedem
commented
Nov 25, 2022
zsluedem
commented
Nov 25, 2022
|
|
||
| abigen!( | ||
| UserOperation, | ||
| "$OUT_DIR/UserOperation.sol/UserOperationLib.json" |
There was a problem hiding this comment.
@Vid201 Just FYI. Here it would generate the same data structure UserOperation.
There was a problem hiding this comment.
Hmm, ok. Then we can import this data structure in user_operation.rs (and implement additional things that will be needed).
Vid201
reviewed
Nov 25, 2022
zsluedem
force-pushed
the
generate-bindings
branch
from
16c6a10 to
e314234
Compare
Vid201
reviewed
Nov 26, 2022
|
@zsluedem I think we should add info about installing solc to README.md (with link to https://docs.soliditylang.org/en/v0.8.9/installing-solidity.html and version required). |
zsluedem
commented
Nov 27, 2022
|
LGTM! 🚀 |
Vid201
approved these changes
Nov 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first step for #4 .