Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 6.8.7 -- Minor tweaks #112

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Release 6.8.7 -- Minor tweaks #112

merged 6 commits into from
Oct 10, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Oct 9, 2024

Changed

  • Wait to print summary message in case more log events are queued.
  • Use range int syntax
  • Use slices.Contains in place of home-built functions

Fixed

  • Correct minor errors in a comment about ExtraMember config

@briskt briskt requested a review from a team as a code owner October 9, 2024 08:29
@briskt briskt requested review from jason-jackson and hobbitronics and removed request for a team October 9, 2024 08:29
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@briskt briskt merged commit 8174eaf into main Oct 10, 2024
3 checks passed
@briskt briskt deleted the minor-tweaks branch October 10, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-jackson jason-jackson jason-jackson approved these changes

@mtompset mtompset mtompset approved these changes

@hobbitronics hobbitronics Awaiting requested review from hobbitronics hobbitronics is a code owner automatically assigned from silinternational/go-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@briskt @mtompset @jason-jackson