test(visual): change method to wait for image (PostHog#23906)

silentninja · Aug 8, 2024 · 81ed316 · 81ed316
1 parent 1f58d21
commit 81ed316
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/.storybook/test-runner.ts b/.storybook/test-runner.ts
@@ -161,9 +161,8 @@ async function expectStoryToMatchSnapshot(
     })
 
     // Wait for all images to load
-    await page.waitForFunction(() => Array.from(document.images).every((i: HTMLImageElement) => i.complete))
     await waitForPageReady(page)
-    await page.waitForLoadState('networkidle')
+    await page.waitForFunction(() => Array.from(document.images).every((i: HTMLImageElement) => !!i.naturalWidth))
     await page.waitForTimeout(2000)
 
     await check(page, context, browser, 'light', storyContext.parameters?.testOptions?.snapshotTargetSelector)
@@ -174,9 +173,8 @@ async function expectStoryToMatchSnapshot(
     })
 
     // Wait for all images to load
-    await page.waitForFunction(() => Array.from(document.images).every((i: HTMLImageElement) => i.complete))
     await waitForPageReady(page)
-    await page.waitForLoadState('networkidle')
+    await page.waitForFunction(() => Array.from(document.images).every((i: HTMLImageElement) => !!i.naturalWidth))
     await page.waitForTimeout(100)
 
     await check(page, context, browser, 'dark', storyContext.parameters?.testOptions?.snapshotTargetSelector)