feat:新增JS-SDK使用权限签名 #796
Open
feat:新增JS-SDK使用权限签名 #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # work/externalcontact/client.go # work/oauth/oauth.go # work/work.go
# Conflicts: # work/externalcontact/user.go
# Conflicts: # work/message/client.go # work/message/message.go # work/oauth/oauth.go # work/work.go
houseme
reviewed
Sep 27, 2024
| func (js *Js) GetAgentConfig(uri string) (config *Config, err error) { | ||
| config = new(Config) | ||
| var accessToken string | ||
| accessToken, err = js.GetAccessToken() |
There was a problem hiding this comment.
73,74合并处理，下面的78，79也是一样，以及83-86 是不是可以合并定义呢？
houseme
reviewed
Sep 27, 2024
houseme
reviewed
Oct 8, 2024
| // GetAgentConfig 获取jssdk需要的配置参数 | ||
| // uri 为当前网页地址 | ||
| func (js *Js) GetAgentConfig(uri string) (config *Config, err error) { | ||
| config = new(Config) |
There was a problem hiding this comment.
建议 Config 对象在使用时在创建，如在88行之前创建。GetConfig 方法也是同样建议
feat:新增企业微信消息推送接收和发送
added 2 commits
November 15, 2024 11:44
# Conflicts: # credential/work_js_ticket.go # work/js/js.go # work/message/reply.go # work/server/error.go # work/server/server.go # work/server/util.go
Release 2.0 hb
Merge pull request #3 from hb1707/v2
houseme
reviewed
Nov 15, 2024
| "github.com/silenceper/wechat/v2/miniprogram/context" | ||
| "strings" |
There was a problem hiding this comment.
这里strings应该紧跟在fmt 后面，以及第10行的空格不要删除
houseme
reviewed
Nov 15, 2024
| @@ -16,3 +17,16 @@ func Signature(params ...string) string { | |||
| } | |||
| return fmt.Sprintf("%x", h.Sum(nil)) | |||
| } | |||
|
|
|||
| func CalSignature(params ...string) string { | |||
houseme
reviewed
Nov 15, 2024
| import ( | ||
| "encoding/json" | ||
| "fmt" | ||
| "github.com/silenceper/wechat/v2/util" |
There was a problem hiding this comment.
import是按组引入，比如系统包一组，第三方一组，自己的一组，中间用空行分隔
houseme
reviewed
Nov 15, 2024
| Signature string `json:"signature"` | ||
| } | ||
|
|
||
| //NewJs init |
There was a problem hiding this comment.
注释标准是 // 斜杠后面加一个空格之后，再添加方法名称 以及在具体说明
houseme
reviewed
Nov 15, 2024
| import ( | ||
| "encoding/json" | ||
| "fmt" | ||
| "github.com/silenceper/wechat/v2/util" |
houseme
reviewed
Nov 15, 2024
| "github.com/silenceper/wechat/v2/work/context" | ||
| "github.com/silenceper/wechat/v2/work/message" | ||
| log "github.com/sirupsen/logrus" | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.work.weixin.qq.com/document/path/90506