Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom startpage support #66

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

empi89
Copy link
Contributor

@empi89 empi89 commented Jun 14, 2020

Introduced config variable DEFAULT_TEMPLATE to specify a path to a template shown as start page.

Splitted this from #56

Regarding questions of @zorun :

  • Rendering of the layout.html template requires population of session.
  • Using render_template works only when templates are within the source directory. However, I would like to have them in an external path separated from the source code.

@zorun
Copy link
Collaborator

zorun commented Jun 15, 2020

Thanks for coming back after 6 months 👍

Now I better understand what you are trying to do:

  • if you want to display a specific page by default, you should use a redirection
  • if what you want is a custom landing page, you should not need the set_session part

That being said, it seems that the lg.js indeed needs request_type etc from the session. There are some hard-coded cases for request_type == "summary". I think this needs to be sorted out instead of hacking something random into the session state.

What you can try: simplify layout.html so that it only handles the HTML layout and nothing else. Move everything that handles user requests (request_type and so on) to a new template like request.html, and base all existing templates on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants