Fix empty output regression #2198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efore processing even starts" This reverts commit d38ff03.
alerque
force-pushed
the
empty-not-error
branch
from
7f942df to
4730340
Compare
alerque
force-pushed
the
empty-not-error
branch
from
4730340 to
5a7694d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to not throw errors when closing a PDF we couldn't actually start, I busted the ability to generate empty PDFs. Notably
<sile></silewould generate but<sile><nofolios /></sile>would not because there is no output on the page and hence it never gets initialized until it's time to finish. This makes a distinction between needing to possible close open PDF handles and abort after an error and successfully running all processing and outputting a blank canvas if called for.