Math overset/underset and munder/mover spacing #2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omikhleia
added
bug
|
Just for making it easier to understand without checking the test file, is here what it allows: |
alerque
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2133
Did I say that my remaining math tasks would be slightly controversial?
Well, this one isn't really, provides a good TeX-like feature and fixes a spacing weirdness, along with a nice test.
Yet, the code has some smell. Not really what I added, the smell was just here unrevealed, and now we are all eyes on it.
I've spent literally hours to try finding the root cause, with no result, so I went for the most minimal things I could do to make it work without breaking something else (esp. MathML tables)... I cannot spent more efforts here on such a "small" topic, while "accents" are still awaiting and the last big missing block in our math experience...
Still, I'd advocate for the PR to be accepted, it does it's job supporting a missing feature nicely, and maybe one day someone more clever will pinpoint the underlying design issue. Advice is welcome...