Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(math): Support MathML movablelimits attribute #2163

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

Omikhleia
Copy link
Member

@Omikhleia Omikhleia commented Nov 9, 2024

One can't make an omelette without breaking eggs.

I was so focused when I fixed a condition on moveable limits (which I marked as a workaround)... that I didn't realize I had broken my nice previous support for limit-like operators at that point or just earlier...

So I guess it's time to remove the workaround and move forward supporting the movablelimits attribute properly.

Note: It's still not perfect -- I know there's still a lot to refactor in the unicode symbols and atom types... But this one takes time to be done properly: merging our symbol definitions with the MathML "operator dictionary" extracted from the Unicode data files...

@Omikhleia Omikhleia added the enhancement Software improvement or feature request label Nov 9, 2024
@Omikhleia Omikhleia added this to the v0.15.6 milestone Nov 9, 2024
@Omikhleia Omikhleia requested a review from a team as a code owner November 9, 2024 19:41
@Omikhleia Omikhleia self-assigned this Nov 9, 2024
@alerque alerque merged commit 4379347 into sile-typesetter:master Nov 13, 2024
20 checks passed
@Omikhleia Omikhleia deleted the feat-mathml-movablelimits branch November 23, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Software improvement or feature request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants