Extend SU.collatedSort for complex table sorting #2105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed when working on #2082 : Our
SU.collatedSort()
works on list of strings only:My own bad at the time (#1632)... but we can't use it to sort structured (key-value) tables with a comparison callback, as one would do with
table.sort()
.Of course there's a workaround, but it's a bit annoying (comparing for string equality, then performing a second ICU comparison for ordering)
So this PR is a proposal for supporting it, as:
In other terms: