Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed types #629

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed types #629

wants to merge 2 commits into from

Conversation

zigazajc007
Copy link

@zigazajc007 zigazajc007 commented Apr 29, 2024

Related to issue #614

Registry<RegistryContentType = PrometheusContentType>

As PrometheusContentType is assigned to RegistryContentType, the typescript will automatically exclude OpenMetricsContentType from RegistryContentType in Registry. So to solve this issue, we can just manually tell typescript that provided value can be PrometheusContentType or OpenMetricsContentType.

@zigazajc007
Copy link
Author

Is this everything that is needed or do I still need to write a Changelog?

@SimenB
Copy link
Collaborator

SimenB commented Apr 29, 2024

I messed around with the lint error in #630, and I might've accidentally fixed this? Could you check? If still broken, this needs a quick rebase 🙂

@zigazajc007
Copy link
Author

Tried method in #630 but it doesn't work.

image

I'm using typescript from Bun.

@SimenB
Copy link
Collaborator

SimenB commented Jun 22, 2024

Fair - mind rebasing? 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants