perf: swap order of escape regexes to avoid lookahead (#546)

* swap regex order to avoid lookahead * changelog * changelog formatting apparently
siimon · Mar 9, 2023 · 3f25c32 · 3f25c32
1 parent 3f96770
commit 3f25c32
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,9 @@ project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Changed
 
+- Refactor `escapeString` helper in `lib/registry.js` to improve performance and
+ avoid an unnecessarily complex regex.
+
 ### Added
 
 - Support for OpenMetrics and Exemplars

diff --git a/lib/registry.js b/lib/registry.js
@@ -214,7 +214,7 @@ function escapeLabelValue(str) {
  return escapeString(str).replace(/"/g, '\\"');
 }
 function escapeString(str) {
- return str.replace(/\n/g, '\\n').replace(/\\(?!n)/g, '\\\\');
+ return str.replace(/\\/g, '\\\\').replace(/\n/g, '\\n');
 }
 function standardizeCounterName(name) {
  return name.replace(/_total$/, '');