Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links for uuid, hash & log index #29

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Conversation

pdeslaur
Copy link
Contributor

@pdeslaur pdeslaur commented Jun 7, 2022

Adds a few links, and also a fly-by change to limit the number of results returned to 5. Given each record is already pretty big - this seems more manageable. We could consider adding pagination later if we decide it makes sense.

Fixes #27

@vercel
Copy link

vercel bot commented Jun 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rekor-search-ui ✅ Ready (Inspect) Visit Preview Jun 8, 2022 at 5:09PM (UTC)

@di
Copy link
Member

di commented Jun 8, 2022

and also a fly-by change to limit the number of results returned to 5. Given each record is already pretty big - this seems more manageable. We could consider adding pagination later if we decide it makes sense.

Could we implement pagination first? Having the results limited to 5 is fairly limiting.

@pdeslaur
Copy link
Contributor Author

pdeslaur commented Jun 8, 2022

Could we implement pagination first? Having the results limited to 5 is fairly limiting.

That's fair - I'll track pagination in #30

Copy link

@katjuell katjuell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@pdeslaur pdeslaur merged commit 29b20a2 into sigstore:main Jun 14, 2022
@pdeslaur pdeslaur deleted the add-links branch June 14, 2022 16:46
kahboom pushed a commit to kahboom/rekor-search-ui that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make log index / uuid / etc linkable
3 participants