Move to clap derive #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey man, thanks for this - would you mind addressing the conflicts? was based on stable but should be unstable |
…e-to-clap-derive
…anchor into migrate-to-clap-derive
|
sorry about that, conflicts should be resolved now |
AgeManning
reviewed
Oct 23, 2024
…anchor into migrate-to-clap-derive
AgeManning
reviewed
Oct 23, 2024
anchor/client/src/config.rs
Outdated
| // TODO define secrets_dir flag | ||
| // if cli_args.secrets_dir.is_some() { | ||
| // secrets_dir = cli_args.secrets_dir; | ||
| // } |
There was a problem hiding this comment.
ah yep, its now added
AgeManning
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move from clap builder to clap derive. Clap derive is a bit nicer to use because you can define the flag types alongside the flag definitions. This removes the need to use the cli helpers
parse_optionalandparse_required.