Additional changes and fixes to the GitHub CI #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is meant to add on #141 with small fixes and to test the CI pipeline on merge.
It introduces the following changes:
on-mergeworkflow dedicated to thedeploy-docjob. This is redundant because, once a PR is merged by a maintainer, theper-commitpipeline will trigger (in fact, merging a PR counts as a push action) and it will already execute thedeploy-docjob at the end. I checked on the main ns-3 GitLab repository, and confirmed that there too theper-commitpipeline is run on PR merge.