-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding MIC Trailer (Issue #123) #126
Open
sanjay-charran
wants to merge
11
commits into
signetlabdei:develop
Choose a base branch
from
sanjay-charran:mic_iss123
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(0x00000000) for testing, and fixed de/serialization misalignments for MIC
… UL/DL and LoRaWAN version
…from ClassAEndDeviceLorawanMac to EndDeviceLorawanMac, and added in DevNonce (join-accept counter)
…k server to each endnode having its own record
non-det-alle
force-pushed
the
develop
branch
4 times, most recently
from
November 10, 2023 12:48
6e9060a
to
9d61a45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MIC Trailer (Issue #123):
Proposed Changes
Added two files (one header and one source) for Trailer:
model/lorawan-mic-trailer: Added in AES128_CMAC and AES-128 cipher (needed for AES128_CMAC), MIC calculation and verification (See LoRaWAN Specification Section 4.4) for both UL and DL and v1.0 and v1.1 network servers, and functions for packing B0/B1 blocks
model/end-device-lorawan-mac: Added function for handling the MIC calculation with all required parameters and added the necessary parameters to the class (some are related to join procedure which requires them to be set manually due to this not being implemented in the module) and had the MIC trailer be calculated and added to the packets before transmission
-helper/lorawan-mac-helper: Added functionality for generating JoinEUI and NwkKey keys for each end device