Skip to content

Commit

Permalink
Remove "applications" module from dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
non-det-alle committed Oct 9, 2024
1 parent bc9d6f3 commit 761a2c7
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/actions/build/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ runs:
run: >
CXX=$COMPILER ./ns3 configure -d $MODE -GNinja
--enable-examples --enable-tests --enable-asserts --enable-werror
--enable-modules "lorawan;applications" $EXTRA_OPTIONS
--enable-modules lorawan $EXTRA_OPTIONS
# Build steps
- name: "Build ns-3"
shell: bash
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/linting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
run: >
./ns3 configure -d debug
--enable-examples --enable-tests --enable-asserts
--enable-modules "lorawan;applications"
--enable-modules lorawan
--enable-clang-tidy
# Use a trick (git diff on empty tag) to only run clang-tidy on the lorawan module
- name: "Running clang-tidy"
Expand Down
6 changes: 2 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,9 @@ Finally, ensure tests run smoothly with:
./test.py
```

If the script reports that all tests passed or that just `three-gpp-propagation-loss-model` failed[^1], you are good to go.
If the script reports that all tests passed you are good to go.

If other tests fail or crash, consider filing an issue.

[^1]: This is due to [a bug in the current ns-3 version](https://gitlab.com/nsnam/ns-3-dev/-/issues/965) when restricting compilation to the lorawan module and its dependencies. If you need to use the `three-gpp-propagation-loss-model`, you can solve this by compiling ns-3 as a whole or with the `--enable-modules "lorawan;applications"` option to reduce compilation time.
If some tests fail or crash, consider filing an issue.

## Usage examples

Expand Down

0 comments on commit 761a2c7

Please sign in to comment.