[mod_sofia] Fix sip_invite_to_uri without host #1791
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`sofia_outgoing_channel()` sets the `tech_pvt->dest_to` and handles if sip_invite_to_uri doesn't have the host part in it, but that was being overwritten in `sofia_glue_do_invite` that sets the to_str to the sip_invite_to_uri and overwrites the `tech_pvt->dest_to`
|
The only thing I could see this interacting with is sofia_recovery_callback, but that should be checked/re-tested to be sure. |
|
was closed by mistake |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sofia_outgoing_channel()sets thetech_pvt->dest_toand handles if sip_invite_to_uri doesn't have the host part in it, but that was being overwritten insofia_glue_do_invitethat sets the to_str to the sip_invite_to_uri and overwrites thetech_pvt->dest_totechnically the whole ternary isn't needed as
tech_pvt->dest_tois already being set insofia_outgoing_channelandtech_pvt->dest_towill have the value ofsip_invite_to_uriif it's set on the channel