Skip to content

Commit

Permalink
Merge pull request #2543 from signalwire/risky
Browse files Browse the repository at this point in the history
[Core] rtp_common_write: Coverity 1227609 Calling risky function
  • Loading branch information
andywolk authored Jul 29, 2024
2 parents be3c0b3 + b38d879 commit 4eefe82
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/switch_rtp.c
Original file line number Diff line number Diff line change
Expand Up @@ -8267,11 +8267,11 @@ static int rtp_common_write(switch_rtp_t *rtp_session,
if (switch_rtp_test_flag(rtp_session, SWITCH_RTP_FLAG_VIDEO)) {
int external = (flags && *flags & SFF_EXTERNAL);
/* Normalize the timestamps to our own base by generating a made up starting point then adding the measured deltas to that base
so if the timestamps and ssrc of the source change, it will not break the other end's jitter bufffer / decoder etc *cough* CHROME *cough*
so if the timestamps and ssrc of the source change, it will not break the other end's jitter buffer / decoder etc *cough* CHROME *cough*
*/

if (!rtp_session->ts_norm.ts) {
rtp_session->ts_norm.ts = (uint32_t) rand() % 1000000 + 1;
rtp_session->ts_norm.ts = (uint32_t) switch_rand() % 1000000 + 1;
}

if (!rtp_session->ts_norm.last_ssrc || send_msg->header.ssrc != rtp_session->ts_norm.last_ssrc || rtp_session->ts_norm.last_external != external) {
Expand Down

0 comments on commit 4eefe82

Please sign in to comment.