Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: container start test #275

Merged
merged 38 commits into from
May 1, 2024
Merged

fix: container start test #275

merged 38 commits into from
May 1, 2024

Conversation

ryanwi
Copy link
Collaborator

@ryanwi ryanwi commented Apr 30, 2024

Problem

The docker build load was failing which preventing the container test from having a container to test against. Docker doesn't support load with multiple architectures. This makes that more clear while still allowing for repos to publish images for multiple architectures.

Container test also would be preferred to happen after the container has had a chance to startup. But, maybe we need to support both and be more flexible?

Changes

  • Allow container test to be executed after the container's default cmd has had time to run
  • Only build single platform for load [1]
  • git refs are for debugging/testing, can still demonstrate this as is. I will revert those once we're good with the other changes.

References:
[1] docker/buildx#59

@ryanwi ryanwi requested review from lucasmellos and a team April 30, 2024 01:17
@ryanwi ryanwi changed the title Debug container start test fix: container start test May 1, 2024
@ryanwi ryanwi merged commit f649a2e into main May 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants