Skip to content

Commit

Permalink
Updated base library to fix issues with timezone parsing, and optiona…
Browse files Browse the repository at this point in the history
…l unreach field
  • Loading branch information
signalkraft committed Sep 30, 2024
1 parent b2ff786 commit 430aadf
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 14 deletions.
22 changes: 11 additions & 11 deletions custom_components/mypyllant/climate.py
Original file line number Diff line number Diff line change
Expand Up @@ -761,12 +761,12 @@ async def async_set_temperature(self, **kwargs: Any) -> None:
else:
_LOGGER.warning("Can't determine operation type on %s", self.zone.name)

if target_temp_low is not None:
if (
target_temp_low is not None
and target_temp_low != self.zone.desired_room_temperature_setpoint_heating
):
# Heating temperature
if (
self.zone.heating.operation_mode_heating == ZoneOperatingMode.MANUAL
and target_temp_low != self.zone.heating.manual_mode_setpoint_heating
):
if self.zone.heating.operation_mode_heating == ZoneOperatingMode.MANUAL:
_LOGGER.debug(
"Setting heating manual temperature on %s to %s",
self.zone.name,
Expand Down Expand Up @@ -794,12 +794,13 @@ async def async_set_temperature(self, **kwargs: Any) -> None:
)
await self.set_quick_veto(temperature=target_temp_low)

if target_temp_high is not None and self.zone.cooling:
if (
target_temp_high is not None
and self.zone.cooling
and target_temp_high != self.zone.desired_room_temperature_setpoint_cooling
):
# Cooling temperature
if (
self.zone.cooling.operation_mode_cooling == ZoneOperatingMode.MANUAL
and target_temp_high != self.zone.cooling.manual_mode_setpoint_cooling
):
if self.zone.cooling.operation_mode_cooling == ZoneOperatingMode.MANUAL:
_LOGGER.debug(
"Setting cooling manual temperature on %s to %s",
self.zone.name,
Expand All @@ -812,7 +813,6 @@ async def async_set_temperature(self, **kwargs: Any) -> None:
elif (
self.zone.cooling.operation_mode_cooling
== ZoneOperatingMode.TIME_CONTROLLED
and target_temp_high != self.zone.cooling.setpoint_cooling
):
_LOGGER.debug(
"Setting cooling time controlled temperature on %s to %s",
Expand Down
2 changes: 1 addition & 1 deletion custom_components/mypyllant/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"iot_class": "cloud_polling",
"issue_tracker": "https://github.com/signalkraft/mypyllant-component/issues",
"requirements": [
"myPyllant==0.8.26"
"myPyllant==0.8.28"
],
"version": "v0.8.13"
}
2 changes: 1 addition & 1 deletion custom_components/mypyllant/services.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ set_cooling_for_days:
datetime:
duration_days:
name: Duration
description: Duration in days (only supported on VRC700 controllers)
description: Duration in days (required on VRC700 controllers)
example: 3
selector:
number:
Expand Down
2 changes: 1 addition & 1 deletion dev-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ types-PyYAML~=6.0.12.20240311

# Need specific versions
pytest-homeassistant-custom-component==0.13.142
myPyllant==0.8.26
myPyllant==0.8.28

# Versions handled by pytest-homeassistant-custom-component
freezegun
Expand Down

0 comments on commit 430aadf

Please sign in to comment.