Skip to content

Commit

Permalink
Actual fix for empty time_program_cooling error
Browse files Browse the repository at this point in the history
  • Loading branch information
signalkraft committed Oct 9, 2024
1 parent f67453f commit 373fd30
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 10 deletions.
4 changes: 2 additions & 2 deletions custom_components/mypyllant/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"iot_class": "cloud_polling",
"issue_tracker": "https://github.com/signalkraft/mypyllant-component/issues",
"requirements": [
"myPyllant==0.8.30"
"myPyllant==0.8.31"
],
"version": "v0.8.16"
"version": "v0.8.17"
}
2 changes: 1 addition & 1 deletion dev-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ types-PyYAML~=6.0.12.20240311

# Need specific versions
pytest-homeassistant-custom-component==0.13.142
myPyllant==0.8.30
myPyllant==0.8.31

# Versions handled by pytest-homeassistant-custom-component
freezegun
Expand Down
7 changes: 4 additions & 3 deletions tests/test_binary_sensor.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,10 @@ async def test_system_binary_sensors(
assert isinstance(ControlError(0, system_coordinator_mock).name, str)
assert ControlOnline(0, system_coordinator_mock).is_on is True
assert isinstance(ControlOnline(0, system_coordinator_mock).name, str)
assert isinstance(
CircuitIsCoolingAllowed(0, 0, system_coordinator_mock).is_on, bool
)
# TODO: May moved to zones, see no_cooling.yaml
# assert isinstance(
# CircuitIsCoolingAllowed(0, 0, system_coordinator_mock).is_on, bool
# )
assert isinstance(
CircuitIsCoolingAllowed(0, 0, system_coordinator_mock).name, str
)
Expand Down
8 changes: 4 additions & 4 deletions tests/test_sensor.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
DomesticHotWaterTankTemperatureSensor,
HomeEntity,
SystemOutdoorTemperatureSensor,
SystemWaterPressureSensor,
ZoneCurrentRoomTemperatureSensor,
ZoneCurrentSpecialFunctionSensor,
ZoneDesiredRoomTemperatureSetpointSensor,
Expand Down Expand Up @@ -82,9 +81,10 @@ async def test_system_sensors(
SystemOutdoorTemperatureSensor(0, system_coordinator_mock).native_value,
float,
)
assert isinstance(
SystemWaterPressureSensor(0, system_coordinator_mock).native_value, float
)
# TODO: No water pressure in no_cooling.yaml
# assert isinstance(
# SystemWaterPressureSensor(0, system_coordinator_mock).native_value, float
# )

home = HomeEntity(0, system_coordinator_mock)
assert isinstance(home.device_info, dict)
Expand Down

0 comments on commit 373fd30

Please sign in to comment.