Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Quote reply with Sticker/Contact/Docs #13924

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sagar0-0
Copy link
Contributor

First time contributor checklist

Contributor checklist

  • Device A, Android X.Y.Z
  • Device B, Android Z.Y
  • Virtual device W, Android Y.Y.Z
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

This changes include supporting following features/capabilities:

  1. Quote reply to a message with a Sticker.
  2. Quote reply to a message with sharing a contact.
  3. Quote reply to a message by sharing a document.
  4. Quote reply to a message with a sticker from your keyboard.

Optionally: We can check if the message is a quoted reply then we can show the background for stickers too. Like in other apps.
Not covered: Clicking on the quoteView won't show the ripple to the sticker message. This can be done by adding a background or any other approaches. I have not changed anything with it to keep the PR more specific.

@greyson-signal
Copy link
Contributor

Hi there, we can't ship this because other clients can't properly render some of these combinations. In the case of stickers, we also had plans for more specific UX.

@Sagar0-0
Copy link
Contributor Author

Sounds reasonable. Thanks for letting me know, I'll keep these scenarios in mind

@Sagar0-0
Copy link
Contributor Author

@greyson-signal I have tested the UI for the desktop and iOS app. For desktops, this renders the same thing it does on Android.

Chat

And for iOS, this won't show the quote, which means this won't make any difference for iOS.

I think this won't break or have any rendering issues for other platforms too. And, iOS team can also support it easily. Let me know your views.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants