Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement wildcard select ilike #22

Merged
merged 7 commits into from
Apr 20, 2024

Conversation

HiranmayaGundu
Copy link

Implements parsing for SELECT * ILIKE ... which is valid syntax in snowflake: https://docs.snowflake.com/en/sql-reference/sql/select

Via googling, it seems like only snowflake supports this syntax. I could not find any other dialect that does. Snowflake does not allow SELECT * ILIKE <pattern> EXCLUDE <column> so I implemented that as well.

@HiranmayaGundu HiranmayaGundu requested a review from jmhain April 19, 2024 23:06
@coveralls
Copy link

coveralls commented Apr 19, 2024

Pull Request Test Coverage Report for Build 8761418278

Details

  • 39 of 44 (88.64%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 87.826%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/query.rs 6 8 75.0%
tests/sqlparser_snowflake.rs 16 19 84.21%
Totals Coverage Status
Change from base Build 8726038305: 0.001%
Covered Lines: 20619
Relevant Lines: 23477

💛 - Coveralls

src/ast/query.rs Outdated Show resolved Hide resolved
src/parser/mod.rs Outdated Show resolved Hide resolved
src/parser/mod.rs Outdated Show resolved Hide resolved
src/ast/query.rs Outdated Show resolved Hide resolved
src/parser/mod.rs Outdated Show resolved Hide resolved
src/parser/mod.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@jmhain jmhain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@HiranmayaGundu HiranmayaGundu merged commit 9889b24 into main Apr 20, 2024
20 checks passed
@HiranmayaGundu HiranmayaGundu deleted the hiran/snowflake-ilike-select-wildcard branch April 20, 2024 01:07
jmhain added a commit that referenced this pull request Apr 30, 2024
This reverts commit 9889b24, reversing
changes made to 16cdc92.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants