Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sigma: support for parsing @sigma table factors and expressions #19

Merged
merged 3 commits into from
Mar 18, 2024
Merged

sigma: support for parsing @sigma table factors and expressions #19

merged 3 commits into from
Mar 18, 2024

Conversation

jmhain
Copy link
Collaborator

@jmhain jmhain commented Mar 18, 2024

No description provided.

@coveralls
Copy link

coveralls commented Mar 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8329336491

Details

  • 35 of 37 (94.59%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 87.807%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/query.rs 4 5 80.0%
src/parser/mod.rs 13 14 92.86%
Files with Coverage Reduction New Missed Lines %
src/ast/query.rs 1 83.12%
Totals Coverage Status
Change from base Build 8159623444: 0.01%
Covered Lines: 20553
Relevant Lines: 23407
💛 - Coveralls

purvilmehta06
purvilmehta06 approved these changes Mar 18, 2024
View reviewed changes
Copy link

@purvilmehta06 purvilmehta06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmhain jmhain merged commit eda99cd into main Mar 18, 2024
20 checks passed
@jmhain jmhain deleted the joey/sigma-stuff branch March 18, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purvilmehta06 purvilmehta06 purvilmehta06 approved these changes

@jlgale jlgale Awaiting requested review from jlgale

@sinanunan sinanunan Awaiting requested review from sinanunan

@alexiscjohnson alexiscjohnson Awaiting requested review from alexiscjohnson

@albert-sigma albert-sigma Awaiting requested review from albert-sigma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmhain @coveralls @purvilmehta06